New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SQL: Add CAST
and CONVERT
to SHOW FUNCTIONS
#34940
Conversation
Pinging @elastic/es-search-aggs |
retest this please |
@bpintea I've chosen to show |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would stick with SCALAR
since essentially that's what they are doing. DATA_TYPE_CONVERSION
is a long description (with underscores) and I'm not sure what are the expected grouping names.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
AFA ODBC is concerned, the way we list the function is orthogonal to it; i.e. there's no API which maps directly to this catalog call a.t.m. AFAI can tell, ODBC lists it however as a scalar function, under the type A while ago we have decided not to obtain this information from ES/SQL dynamically, but to rather hard coded it in the driver. But even if we were to change that decision, in the listing we now have, the |
@bpintea Thanks a lot for looking into this! Changing the type to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Backported to |
Backported to |
Fixes: #34939