Watcher: fix metric stats names #34951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current watcher stats metric names doesn't match the current documentation. This commit fixes the behavior of `queued_watches` metric, deprecates `pending_watches` metric and adds `current_watches` to match the documented behavior. It also fixes the documentation, which introduced `executing_watches` metric that was never added. Fixes elastic#34865
|
Pinging @elastic/es-core-infra |
hub-cap
approved these changes
Oct 29, 2018
There was a problem hiding this comment.
lol, looks like youve dealt with deprecations before :P
LGTM but would like @spinscale to have a look since im not super familiar w these params
imotov
added a commit
to imotov/elasticsearch
that referenced
this pull request
Oct 30, 2018
WIP, Depends on elastic#34951 Relates elastic#29827
spinscale
approved these changes
Oct 31, 2018
| "Test watcher stats current watches": | ||
| - skip: | ||
| version: " - 6.99.99" | ||
| reason: materics were fixed in 7.0.0 |
| "Test watcher stats queued watches": | ||
| - skip: | ||
| version: " - 6.99.99" | ||
| reason: materics were fixed in 7.0.0 |
| "Test watcher stats queued watches using pending_watches": | ||
| - skip: | ||
| version: " - 6.99.99" | ||
| reason: materics were fixed in 7.0.0 |
imotov
added a commit
that referenced
this pull request
Nov 1, 2018
The current watcher stats metric names doesn't match the current documentation. This commit fixes the behavior of `queued_watches` metric, deprecates `pending_watches` metric and adds `current_watches` to match the documented behavior. It also fixes the documentation, which introduced `executing_watches` metric that was never added. Fixes #34865
48 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current watcher stats metric names doesn't match the current
documentation. This commit fixes the behavior of
queued_watchesmetric, deprecates
pending_watchesmetric and addscurrent_watchesto match the documented behavior. It also fixes the documentation, which
introduced
executing_watchesmetric that was never added.Fixes #34865