NETWORKING: Simplify Transport Compression Setting #34959
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Individual setting should only be able to negate the global compress setting since `org.elasticsearch.transport.TcpTransport#canCompress` ensures that compression only ever happens if the global compression is enabled regardless of the `TransportRequestOptions` * Disables compression of segment files during recovery to bring code and comment in line with each other * Fixes elastic#33844
original-brownbear
added
>enhancement
:Distributed/Network
|
Pinging @elastic/es-distributed |
|
Relates #36399 |
|
I think I can just close here right? This was handled by @tbrooks8 meanwhile elsewhere? |
tomcallahan
removed
the
:Distributed/Recovery
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
org.elasticsearch.transport.TcpTransport#canCompressensures that compression only ever happens if the global compression is enabled regardless of theTransportRequestOptions