Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQL: Optimizer rule for folding nullable expressions #35080

Merged
merged 2 commits into from Oct 30, 2018
Merged

SQL: Optimizer rule for folding nullable expressions #35080

merged 2 commits into from Oct 30, 2018

Conversation

costin
Copy link
Member

@costin costin commented Oct 30, 2018

Add optimization for folding NULLable expressions when dealing with a
NULL argument. This is a variant of folding for the NULL case.

Fix #34826

@costin
SQL: Optimizer rule for folding nullable expressions
46e9394 
Add optimization for folding NULLable expressions when dealing with a
NULL argument. This is a variant of folding for the NULL case.

Fix elastic#34826
@costin costin requested review from astefan and matriv October 30, 2018 11:57
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

matriv
matriv reviewed Oct 30, 2018
View reviewed changes
x-pack/plugin/sql/src/main/java/org/elasticsearch/xpack/sql/optimizer/Optimizer.java Outdated
@@ -683,7 +687,7 @@ protected LogicalPlan rule(Filter filter) {
return filter.child();
}
// TODO: add comparison with null as well
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can remove the TODO

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. Thanks

matriv
matriv approved these changes Oct 30, 2018
View reviewed changes
Copy link
Contributor

@matriv matriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! just one comment

@costin costin merged commit 6abddd8 into elastic:master Oct 30, 2018
@costin costin deleted the fix-34826 branch October 30, 2018 18:17
costin added a commit that referenced this pull request Oct 30, 2018
@costin
SQL: Optimizer rule for folding nullable expressions (#35080)
727f39e 
Add optimization for folding nullable expressions with a NULL 
argument. This is a variant of folding for the NULL case.

Fix #34826

(cherry picked from commit 6abddd8)
costin added a commit that referenced this pull request Oct 30, 2018
@costin
SQL: Optimizer rule for folding nullable expressions (#35080)
0482e15 
Add optimization for folding nullable expressions with a NULL 
argument. This is a variant of folding for the NULL case.

Fix #34826

(cherry picked from commit 6abddd8)
@colings86 colings86 added v6.5.0 and removed v6.5.1 labels Nov 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matriv matriv matriv approved these changes

@astefan astefan Awaiting requested review from astefan

Assignees
No one assigned
Labels
:Analytics/SQL SQL querying >enhancement v6.5.0 v6.6.0 v7.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@costin @elasticmachine @matriv @colings86