Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Drop settings member from AbstractComponent #35083

Merged
merged 6 commits into from
Oct 30, 2018

Commits on Oct 29, 2018

  1. Core: Drop settings member from AbstractComponent

    Drops the `Settings` member from `AbstractComponent`, moving it from the
    base class on to the classes that use it. For the most part this is a
    mechanical change that doesn't drop `Settings` accesses. The one
    exception to this is naming threads where it switches from an invocation
    that passes `Settings` and extracts the node name to one that explicitly
    passes the node name.
    
    This change doesn't drop the `Settings` argument from
    `AbstractComponent`'s ctor because this change is big enough as is.
    We'll do that in a follow up change.
    nik9000 committed Oct 29, 2018
    Configuration menu
    Copy the full SHA
    b5192e3 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2018

  1. Fix order

    nik9000 committed Oct 30, 2018
    Configuration menu
    Copy the full SHA
    11092e0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c2ce7be View commit details
    Browse the repository at this point in the history
  3. Sneaky sneaky

    nik9000 committed Oct 30, 2018
    Configuration menu
    Copy the full SHA
    378b411 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c6ec0d0 View commit details
    Browse the repository at this point in the history
  5. Cleanup

    nik9000 committed Oct 30, 2018
    Configuration menu
    Copy the full SHA
    d0c059c View commit details
    Browse the repository at this point in the history