Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLRC: add support for the clear realm cache API #35163

Merged
merged 5 commits into from Nov 6, 2018

Conversation

jaymode
Copy link
Member

@jaymode jaymode commented Nov 1, 2018

This change adds support for clearing the cache of a realm. The realms
cache may contain a stale set of credentials or incorrect role
assignment, which can be corrected by clearing the cache of the entire
realm or just that of a specific user.

Relates #29827

This change adds support for clearing the cache of a realm. The realms
cache may contain a stale set of credentials or incorrect role
assignment, which can be corrected by clearing the cache of the entire
realm or just that of a specific user.

Relates elastic#29827
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@jaymode
Copy link
Member Author

jaymode commented Nov 1, 2018

cc @elastic/es-security

Copy link
Contributor

@albertzaharovits albertzaharovits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
If I were to add anything, I would more thoroughly test the ClearRealmCacheResponse, especially that nowAbstractStreamableXContentTestCase is a thing. But the response is simple enough for this to not be necessary.

@jaymode
Copy link
Member Author

jaymode commented Nov 2, 2018

run sample packaging tests

Copy link
Member

@jkakavas jkakavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

*
* @param request the request with the realm names and usernames to clear the cache for
* @param options the request options (e.g. headers), use {@link RequestOptions#DEFAULT} if nothing needs to be customized
* @return the response from the enable user call
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/enable user/clear cache

@jaymode jaymode merged commit 6f6b265 into elastic:master Nov 6, 2018
@jaymode jaymode deleted the hlrc_clear_realm_cache branch November 6, 2018 20:12
jaymode added a commit that referenced this pull request Nov 6, 2018
This change adds support for clearing the cache of a realm. The realms
cache may contain a stale set of credentials or incorrect role
assignment, which can be corrected by clearing the cache of the entire
realm or just that of a specific user.

Relates #29827
pgomulka pushed a commit to pgomulka/elasticsearch that referenced this pull request Nov 13, 2018
This change adds support for clearing the cache of a realm. The realms
cache may contain a stale set of credentials or incorrect role
assignment, which can be corrected by clearing the cache of the entire
realm or just that of a specific user.

Relates elastic#29827
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants