Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Pull "skip assemble on qa" to common build #35214

Merged
merged 1 commit into from Nov 5, 2018

Conversation

nik9000
Copy link
Member

@nik9000 nik9000 commented Nov 2, 2018

Pull all of the logic that we use to skip the assemble and
dependenciesInfo tasks on qa projects into one spot in our root
build file.

Pull all of the logic that we use to skip the `assemble` and
`dependenciesInfo` tasks on `qa` projects into one spot in our root
build file.
@nik9000 nik9000 added :Delivery/Build Build or test infrastructure v7.0.0 v6.6.0 labels Nov 2, 2018
Copy link
Member

@jasontedor jasontedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It was only a matter of time, thank you for picking it up.

Copy link
Contributor

@alpar-t alpar-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Always good to see less build code :)

@nik9000 nik9000 merged commit f72ef9b into elastic:master Nov 5, 2018
nik9000 added a commit that referenced this pull request Nov 5, 2018
Pull all of the logic that we use to skip the `assemble` and
`dependenciesInfo` tasks on `qa` projects into one spot in our root
build file.
@jimczi jimczi added v7.0.0-beta1 and removed v7.0.0 labels Feb 7, 2019
@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Delivery/Build Build or test infrastructure >non-issue Team:Delivery Meta label for Delivery team v6.6.0 v7.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants