Fix DeleteRequest validation for nullable or empty id/type #35314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation for null and/or empty id/type Closes elastic#35297
vladimirdolzhenko
added
:Distributed/CRUD
|
Pinging @elastic/es-distributed |
klobin
reviewed
Nov 6, 2018
server/src/main/java/org/elasticsearch/action/delete/DeleteRequest.java
Outdated
Show resolved
Hide resolved
klobin
reviewed
Nov 6, 2018
server/src/main/java/org/elasticsearch/action/explain/ExplainRequest.java
Outdated
Show resolved
Hide resolved
dnhatn
approved these changes
Nov 6, 2018
server/src/main/java/org/elasticsearch/action/delete/DeleteRequest.java
Outdated
Show resolved
Hide resolved
javanna
approved these changes
Nov 7, 2018
|
I updated labels, I think we should backport this fix to 6.5, 6.4 and 5.6 |
pgomulka
pushed a commit
to pgomulka/elasticsearch
that referenced
this pull request
Nov 13, 2018
…ation for null and/or empty id/type (elastic#35314) Closes elastic#35297
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually if you send a delete document request like
DeleteRequest("index", "", "")instead of error you effectively execute delete index and get NPE as{acknowledged=true}could not be parsed intoDeleteResponseThis PR as well fixes GetRequest / UpdateRequest / ExplainRequest validation for null and/or empty id/type.
Closes #35297