Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a java level freeze/unfreeze API #35353

Merged
merged 12 commits into from Nov 10, 2018
Merged

Conversation

s1monw
Copy link
Contributor

@s1monw s1monw commented Nov 7, 2018

This change adds a high level freeze API that allows to mark an
index as frozen and vice versa. Indices must be closed in order to
become frozen and an open but frozen index must be closed to be
defrosted. This change also adds a index.frozen setting to
mark frozen indices and integrates the frozen engine with the
SearchOperationListener that resets and releases the directory
reader after and before search phases.

Relates to #34352
Depends on #34357

This change adds a high level freeze API that allows to open an
index frozen and vice versa. Indices must be closed in order to
become frozen and an open but frozen index must be closed to be
defrosted. This change also adds a `index.frozen` setting to
mark frozen indices and integrates the frozen engine with the
`SearchOperationListener` that resets and releases the directory
reader after and before search phases.

Relates to elastic#34352
Depends on elastic#34357
@s1monw s1monw added >enhancement v7.0.0 :Distributed/Distributed A catch all label for anything in the Distributed Area. If you aren't sure, use this one. v6.6.0 labels Nov 7, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

@s1monw s1monw mentioned this pull request Nov 7, 2018
7 tasks
@s1monw s1monw requested a review from bleskes November 7, 2018 22:07
@s1monw s1monw requested a review from tlrx November 8, 2018 11:02
@s1monw s1monw requested a review from ywelsch November 8, 2018 14:53
@s1monw
Copy link
Contributor Author

s1monw commented Nov 8, 2018

@bleskes I pushed changes to split out the open part of the freezing

Copy link
Member

@tlrx tlrx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very simple - I left some minor comments

@s1monw
Copy link
Contributor Author

s1monw commented Nov 8, 2018

@tlrx I pushed changes

@s1monw s1monw requested a review from tlrx November 8, 2018 19:20
Copy link
Contributor

@bleskes bleskes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left one comment about the handling of index blocks.

Copy link
Member

@tlrx tlrx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left 3 minor comments

@s1monw s1monw merged commit 64df803 into elastic:master Nov 10, 2018
s1monw added a commit that referenced this pull request Nov 10, 2018
This change adds a high level freeze API that allows to mark an
index as frozen and vice versa. Indices must be closed in order to
become frozen and an open but frozen index must be closed to be
defrosted. This change also adds a index.frozen setting to
mark frozen indices and integrates the frozen engine with the
SearchOperationListener that resets and releases the directory
reader after and before search phases.

Relates to #34352
Depends on #34357
pgomulka pushed a commit to pgomulka/elasticsearch that referenced this pull request Nov 21, 2018
This change adds a high level freeze API that allows to mark an
index as frozen and vice versa. Indices must be closed in order to
become frozen and an open but frozen index must be closed to be
defrosted. This change also adds a index.frozen setting to
mark frozen indices and integrates the frozen engine with the
SearchOperationListener that resets and releases the directory
reader after and before search phases.

Relates to elastic#34352
Depends on elastic#34357
@jimczi jimczi added v7.0.0-beta1 and removed v7.0.0 labels Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed/Distributed A catch all label for anything in the Distributed Area. If you aren't sure, use this one. >enhancement v6.6.0 v7.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants