New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HLRC] Added support for CCR Put Follow API #35409
Conversation
This change also adds documentation for the Put Follow API and adds a CCR HLRC integration test.
Pinging @elastic/es-core-infra |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one small change in the constructor and its good to go.
private TimeValue readPollTimeout; | ||
|
||
@Override | ||
public Optional<ValidationException> validate() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets turn this into a constructor that takes these 3 values and make them final in the class. Then you can just remove all of the extra validation stuff and the addValidationError
below.
This change also adds documentation for the Put Follow API and adds a CCR HLRC integration test.
This change also adds documentation for the Put Follow API and adds a CCR HLRC integration test.
This change also adds documentation for the Put Follow API and
adds a CCR HLRC integration test.