[ILM] fix rest-api-spec doc links #35478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talevy
added
>non-issue
:Data Management/ILM+SLM
|
Pinging @elastic/es-core-infra |
colings86
requested changes
Nov 13, 2018
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "ilm.delete_lifecycle": { | |||
| "documentation": "http://www.elastic.co/guide/en/index_lifecycle/current/index_lifecycle.html", | |||
| "documentation": "https://www.elastic.co/guide/en/elasticsearch/reference/current/ilm-delete-lifecycle.html", | |||
There was a problem hiding this comment.
These links are wrong I think (at least they 404) as the API docs are not in the guide book. I think they should be https://www.elastic.co/guide/en/elasticsearch/reference/current/ilm-delete-policy.html, which still 404 because the current version is 6.4 right now but if you replace current with master or 6.x they work so they should be ok when current becomes 6.6
There was a problem hiding this comment.
I'm not sure what is being recommend here. I think the intention of using current here is to prevent the need to update this all the time between versions, and the assumption is these are valid in the branch that it is merged into
colings86
approved these changes
Nov 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the links to the docs from the rest-api-spec were stale. Now that the API docs
for ILM exist, these are updated.