Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove usages of Set<CharSequence> #35501

Merged
merged 1 commit into from
Nov 16, 2018
Merged

Remove usages of Set<CharSequence> #35501

merged 1 commit into from
Nov 16, 2018

Commits on Nov 13, 2018

  1. Remove usages of Set<CharSequence> 

    The javadocs of the CharSequence interface state that not all of its
implementations define the general contracts of the Object#equals and
Object#hashCode methods, therefore it is dangerous to use different CharSequence
instances as elements in a set or as keys in a map. While we probably mostly use
Strings in sets, in some places this is not enforced. To prevent this from
accidentally happening, this change replaces all occurances of Set<CharSequence>
which are currently mostly used in the completion suggester code with the more
concrete usage of Set<String>.
    Christoph Büscher committed Nov 13, 2018
    Configuration menu
    Copy the full SHA
    d0765e3 View commit details
    Browse the repository at this point in the history