DOCS Audit event attributes in new format #35510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertzaharovits
added
>docs
|
Pinging @elastic/es-security |
lcawl
reviewed
Nov 19, 2018
|
|
||
| The following list shows attributes that are common to all audit events. | ||
| Their names and values are analogous to those in the deprecated `logfile` or | ||
| `index` output formats. However, it is expected that the formats will evolve |
There was a problem hiding this comment.
Is it correct that the index output format is deprecated? If not, maybe change this phrase to "... the index or deprecated logfile output format..."
There was a problem hiding this comment.
I intended to keep it vague.
It is not technically deprecated yet. But I very much expect it to be in 6.x . We first need to have the filebeat parse the new logfile format . After that, deprecate it and write a blog post.
Is it really ambiguous as I intended it to be? If it implies that it is deprecated now, then it is wrong and I should correct it.
lcawl
approved these changes
Nov 19, 2018
|
Thank you @lcawl ! |
|
run gradle build tests |
1 similar comment
|
run gradle build tests |
jaymode
approved these changes
Nov 26, 2018
|
run gradle build tests 1 |
albertzaharovits
added a commit
that referenced
this pull request
Nov 28, 2018
Accounts for the `Structured Audit Entries` in the format documentation.
albertzaharovits
added a commit
that referenced
this pull request
Nov 28, 2018
Accounts for the `Structured Audit Entries` in the format documentation.
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Nov 28, 2018
* master: DOCS Audit event attributes in new format (elastic#35510) Scripting: Actually add joda time back to whitelist (elastic#35965) [DOCS] fix HLRC ILM doc misreferenced tag Add realm information for Authenticate API (elastic#35648) [ILM] add HLRC docs to remove-policy-from-index (elastic#35759) [Rollup] Update serialization version after backport [Rollup] Add more diagnostic stats to job (elastic#35471) Build: Fix gradle build for Mac OS (elastic#35968) Adds deprecation logging to ScriptDocValues#getValues. (elastic#34279) [Monitoring] Make Exporters Async (elastic#35765) [ILM] reduce time restriction on IndexLifecycleExplainResponse (elastic#35954) Remove use of AbstractComponent in xpack (elastic#35394) Deprecate types in search and multi search templates. (elastic#35669) Remove fromXContent from IndexUpgradeInfoResponse (elastic#35934)
This was referenced Dec 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the spring cleaning in the audit event attributes docs.
A lot has changed and the docs have been left behind.
Some of the documented updates: