Geo: better handling of malformed geo_points #35554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improves handling of malformed geo_points when `ignore_malformed` is set to true Closes elastic#35419
imotov
added
>bug
:Analytics/Geo
|
Pinging @elastic/es-search-aggs |
cbuescher
requested changes
Nov 20, 2018
| @@ -260,7 +260,11 @@ protected void parse(ParseContext context, GeoPoint point) throws IOException { | |||
| throw new IllegalArgumentException("illegal longitude value [" + point.lon() + "] for " + name()); | |||
| } | |||
| } else { | |||
| GeoUtils.normalizePoint(point); | |||
| if (isNormalizable(point.lat()) && isNormalizable(point.lat())) { | |||
There was a problem hiding this comment.
should one of these be point.lon()?
There was a problem hiding this comment.
If so, there should probably also be a test added that would have caught this.
|
@cbuescher I pushed the changes that you have requested. Could you take another look? |
imotov
added a commit
that referenced
this pull request
Nov 27, 2018
Improves handling of malformed geo_points when `ignore_malformed` is set to true Closes #35419
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves handling of malformed geo_points when
ignore_malformedisset to true
Closes #35419