Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress CachedTimeThread in hot threads output #35558

Merged

Conversation

DaveCTurner
Copy link
Contributor

In #23175 we renamed ThreadPool$EstimatedTimeThread to
ThreadPool$CachedTimeThread but did not update the corresponding entry in
HotThreads#isIdleThread(). This commit addresses this.

In elastic#23175 we renamed `ThreadPool$EstimatedTimeThread` to
`ThreadPool$CachedTimeThread` but did not update the corresponding entry in
`HotThreads#isIdleThread`. This commit addresses this.
@DaveCTurner DaveCTurner added >bug :Core/Infra/Core Core issues without another label v7.0.0 v6.6.0 labels Nov 14, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

Copy link
Member

@jasontedor jasontedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@DaveCTurner DaveCTurner removed the request for review from rjernst November 14, 2018 18:00
Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too

@DaveCTurner DaveCTurner merged commit 928ab6a into elastic:master Nov 15, 2018
@DaveCTurner DaveCTurner deleted the 2018-11-14-cached-time-thread-is-idle branch November 15, 2018 08:25
DaveCTurner added a commit that referenced this pull request Nov 15, 2018
In #23175 we renamed `ThreadPool$EstimatedTimeThread` to
`ThreadPool$CachedTimeThread` but did not update the corresponding entry in
`HotThreads#isIdleThread`. This commit addresses this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Core/Infra/Core Core issues without another label v6.6.0 v7.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants