[Painless] Partially fixes def boxed types casting #35563
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdconrad
added
>bug
:Core/Infra/Scripting
|
Pinging @elastic/es-core-infra |
rjernst
reviewed
Nov 14, 2018
| public static Byte defToByteExplicit(final Object value) { | ||
| if (value == null) { | ||
| return null; | ||
| } else if (value instanceof Character) { |
There was a problem hiding this comment.
I thought byte -> char and char -> byte had to be explicit (in java). Does painless differ here?
There was a problem hiding this comment.
Good catch, you are correct. This is a bug that I'll fix now.
There was a problem hiding this comment.
Note this is the explicit version, though. I corrected the implicit versions.
|
@rjernst Thanks for the review! Will commit as soon as CI passes. |
|
I'm closing this in favor of the quick/easier fix for now (#35653). The casting model in Painless needs to be revisited in a separate follow up as some of the specced out casts do not work as expected, but the fixes need to be given more thought so more problems are not created. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An issue related to implicitly casting to appropriate return types was revealed (#35351). According to the Painless spec (https://www.elastic.co/guide/en/elasticsearch/painless/current/painless-casting.html), def values are allowed to implicitly cast from one boxed type to another boxed type such as
IntegertoDouble. Currently, this not working according to spec. This partially fixes the issue by inserting appropriate methods at compile-time to execute the casts at run-time. The other part of the issue will be a different PR as it needs to fix an issue related to boxing for method parameters at run-time which is trickier due to run-time code path.