[HLRC] Fix issue in equals impl for GlobalOperationPrivileges #35721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes an issue in the equals implementation for GlobalOperationPrivileges and adds few tests.
bizybot
added
v7.0.0
:Core/Java High Level REST Client
:Security/Authorization
|
Pinging @elastic/es-security |
...rc/main/java/org/elasticsearch/client/security/user/privileges/GlobalOperationPrivilege.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/elasticsearch/client/security/user/privileges/GlobalOperationPrivilege.java
Outdated
Show resolved
Hide resolved
...st/java/org/elasticsearch/client/security/user/privileges/GlobalOperationPrivilegeTests.java
Show resolved
Hide resolved
|
I've left some comments. You've touched my purist decisions so I am curious if the status quo broke something in order to possibly revision my stance. |
added 2 commits
November 21, 2018 09:45
- Revert unwanted code changes
|
Hi @albertzaharovits I have addressed the comments by removing the unwanted code changes, keeping those relevant to the fix I thought was needed in the |
bizybot
added a commit
that referenced
this pull request
Nov 27, 2018
This commit fixes an issue in the equals implementation for GlobalOperationPrivileges and adds few tests.
tomcallahan
added
>enhancement
and removed
:Security/Authorization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue in the equals implementation for
GlobalOperationPrivileges and adds few tests.