Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PrimaryAllocationIT#testForceStaleReplicaToBePromotedToPrimary #35728

Merged
merged 4 commits into from
Nov 20, 2018
Merged

Fix PrimaryAllocationIT#testForceStaleReplicaToBePromotedToPrimary #35728

merged 4 commits into from
Nov 20, 2018

Conversation

vladimirdolzhenko
Copy link
Contributor

@vladimirdolzhenko vladimirdolzhenko commented Nov 20, 2018 •
edited

Failure described in #35497 could be reproduced under load or just adding some delay in between reroute command execution and getting cluster state (allocation ids) - in that case recovery already passed and allocation ids contain actual node id rather expected allocation id right after command execution.

The fix is to grab in-sync set of the 1st cluster state change after reroute execution from ClusterService of the node.

Closes #35497

Fix PrimaryAllocationIT#testForceStaleReplicaToBePromotedToPrimary:
1662dd0 
grab in-sync set of the 1st cluster state change after reroute execution

Closes 35497
@vladimirdolzhenko vladimirdolzhenko added >test Issues or PRs that are addressing/adding tests :Distributed/Recovery Anything around constructing a new shard, either from a local or a remote source. v7.0.0 v6.5.0 v6.6.0 labels Nov 20, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

@elastic elastic deleted a comment Nov 20, 2018
DaveCTurner
DaveCTurner reviewed Nov 20, 2018
View reviewed changes
Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Asked for a bit more logging just in case it fails again.

server/src/test/java/org/elasticsearch/cluster/routing/PrimaryAllocationIT.java Outdated Show resolved Hide resolved
server/src/test/java/org/elasticsearch/cluster/routing/PrimaryAllocationIT.java Show resolved Hide resolved
DaveCTurner
DaveCTurner approved these changes Nov 20, 2018
View reviewed changes
Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vladimirdolzhenko
Copy link
Contributor Author

thanks @DaveCTurner

@vladimirdolzhenko vladimirdolzhenko merged commit 953c858 into elastic:master Nov 20, 2018
@vladimirdolzhenko vladimirdolzhenko deleted the fix/35497 branch November 20, 2018 19:05
vladimirdolzhenko added a commit that referenced this pull request Nov 20, 2018
@vladimirdolzhenko
Fix PrimaryAllocationIT#testForceStaleReplicaToBePromotedToPrimary (#…
16fef93 
…35728)

Closes 35497

(cherry picked from commit 953c858)
@vladimirdolzhenko vladimirdolzhenko mentioned this pull request Nov 20, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaveCTurner DaveCTurner DaveCTurner approved these changes

Assignees
No one assigned
Labels
:Distributed/Recovery Anything around constructing a new shard, either from a local or a remote source. >test Issues or PRs that are addressing/adding tests v6.6.0 v7.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sporadic failure in testForceStaleReplicaToBePromotedToPrimary
4 participants
@vladimirdolzhenko @elasticmachine @DaveCTurner @colings86