Handles exists query in composite aggs #35758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the support for exists query in the sorted execution mode of the `composite` aggregation. We'll execute the aggregation from the sorted points and use early termination if the main query is an `exists` query over the first source of the `composite` aggregation.
|
Pinging @elastic/es-search-aggs |
jpountz
approved these changes
Nov 26, 2018
| /** | ||
| * Returns true if we can use <code>query</code> with a {@link SortedDocsProducer} on <code>fieldName</code>. | ||
| */ | ||
| private static boolean checkQuery(Query query, String fieldName) { |
There was a problem hiding this comment.
let's have a more explicit name maybe?
jimczi
added a commit
that referenced
this pull request
Nov 26, 2018
This commit adds the support for exists query in the sorted execution mode of the `composite` aggregation. We'll execute the aggregation from the sorted points and use early termination if the main query is an `exists` query over the first source of the `composite` aggregation.
jimczi
added a commit
that referenced
this pull request
Nov 26, 2018
This commit adds the support for exists query in the sorted execution mode of the `composite` aggregation. We'll execute the aggregation from the sorted points and use early termination if the main query is an `exists` query over the first source of the `composite` aggregation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the support for exists query in the sorted execution mode
of the
compositeaggregation. We'll execute the aggregation from the sortedpoints and use early termination if the main query is an
existsquery over thefirst source of the
compositeaggregation.