TEST: Ensure a manual flush always occur #36188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test testLookupSeqNoByIdInLucene fails because it expects if any change should be visible after a flush. However, that flush might be ignored if the waitIfOngoing parameter is false (the default value), and there is an ongoing flush triggered after merge is running. Closes elastic#35823
dnhatn
added
>test
|
Pinging @elastic/es-distributed |
jpountz
approved these changes
Dec 4, 2018
There was a problem hiding this comment.
Thanks @dnhatn!
This makes me wonder whether calling flush(true, false) makes any sense and whether we should disallow this combination or maybe replace these two booleans with an enum (eg. TRY_FLUSH (false, false), FLUSH_IF_CHANGES (false, true), FORCE_FLUSH (true, true))?
dnhatn
added a commit
that referenced
this pull request
Dec 7, 2018
The test testLookupSeqNoByIdInLucene fails because it expects if any change should be visible after a flush. However, that flush might be ignored if the waitIfOngoing parameter is false (the default value), and there is an ongoing flush triggered after merge is running. Closes #35823
dnhatn
added a commit
that referenced
this pull request
Dec 7, 2018
The test testLookupSeqNoByIdInLucene fails because it expects if any change should be visible after a flush. However, that flush might be ignored if the waitIfOngoing parameter is false (the default value), and there is an ongoing flush triggered after merge is running. Closes #35823
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test
testLookupSeqNoByIdInLucenefails because it expects if anychange should be visible after a flush. However, that flush might be
ignored if the
waitIfOngoingparameter is false (the default value), andthere is an ongoing flush triggered after merge is running.
Closes #35823