SQL: non ISO 8601 versions of DAY_OF_WEEK and WEEK_OF_YEAR functions #36358
Conversation
added the same functions with different functionality. Rewritten the datetime functions documentation to follow the format of the other functions documentation pages.
|
Pinging @elastic/es-search |
| @@ -40,6 +40,12 @@ DOW |SCALAR | |||
| DOY |SCALAR | |||
| HOUR |SCALAR | |||
| HOUR_OF_DAY |SCALAR | |||
| ISODAYOFWEEK |SCALAR | |||
There was a problem hiding this comment.
I think we also need to add these shortcuts:
isodayofweek/isodow ->idow
isoweek -> iw
isoweekofyear -> iwoy
|
run the gradle build tests 1 |
| int dayOfWeek = zdt.get(ChronoField.DAY_OF_WEEK) + 1; | ||
| return dayOfWeek == 8 ? 1 : dayOfWeek; | ||
| }), | ||
| WEEK_OF_YEAR(zdt -> { |
There was a problem hiding this comment.
Could you add here also the difference between iso and non-iso?
| @@ -98,8 +98,10 @@ class org.elasticsearch.xpack.sql.expression.function.scalar.whitelist.InternalS | |||
| # | |||
There was a problem hiding this comment.
Seems we are missing the existing non-iso methods here, and relevant tests that would catch those cases.
There was a problem hiding this comment.
The iso methods are handled through the dateTimeChrono method which also handles the rest of the date time functions. I've renamed the DateTimeExtractor enum values for ISO day_of_week and week_of_year functions, hopefully making this less confusing.
|
|
||
| .Description: | ||
|
|
||
| Extract fields from datetimes by specifying the name of a <<sql-functions-datetime,datetime function>>. |
There was a problem hiding this comment.
I would rephrase: ... from a datetime field or so, I don't like the datetimes plural so much :-)
It's also inconsistent since you use from a datetime elsewhere.
|
Relates: #36417 |
docs page accordingly.
|
@elasticmachine run default distro tests |
Renamed DAY_OF_WEEK and WEEK_OF_YEAR functions to their ISO version and added the same functions with different functionality. Rewritten the datetime functions documentation to follow the format of the other functions documentation pages.
Fixes #36263