Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Ensure total hits are tracked #36374

Conversation

dimitris-athanasiou
Copy link
Contributor

This is in preparation of the anticipated change
that will disable accurate total hits tracking in
searches.

This is in preparation of the anticipated change
that will disable accurate total hits tracking in
searches.
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core

Copy link
Contributor

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@droberts195
Copy link
Contributor

ping @elastic/ml-ui - if there is anywhere in the ML UI where you do a search and rely on the count of hits being accurate in the response you should make a similar change to this in the master branch.

@dimitris-athanasiou dimitris-athanasiou merged commit b8dba16 into elastic:master Dec 7, 2018
@dimitris-athanasiou dimitris-athanasiou deleted the request-total-hits-tracking-where-necessary branch December 7, 2018 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants