Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make node field in JoinRequest private #36405

Merged
merged 1 commit into from
Dec 12, 2018
Merged

Make node field in JoinRequest private #36405

merged 1 commit into from
Dec 12, 2018

Commits on Dec 9, 2018

  1. Make node field in JoinRequest private 

    This commit moves the node field in the JoinRequest object to be a
private field, adding a dedicated accessor. This is a minor breaking
change in that it is no longer possible for all callers to overwrite
this field, but that is a feature.
    @jasontedor
    jasontedor committed Dec 9, 2018
    Configuration menu
    Copy the full SHA
    797bd43 View commit details
    Browse the repository at this point in the history