Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix origin.type for connection_* events #36410

Merged

Conversation

albertzaharovits
Copy link
Contributor

The origin.type field should be rest, transport or local_node, for connection_granted and connection_denied event types, according to the taxonomy we had set here https://www.elastic.co/guide/en/elastic-stack-overview/6.5/audit-event-types.html#audit-event-attributes but it is ip_filter (the same value as event.type).

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-security

@albertzaharovits
Copy link
Contributor Author

run gradle build tests 1

Copy link
Member

@jaymode jaymode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaymode jaymode changed the title MINOR Fix origin.type for connection_* events Fix origin.type for connection_* events Dec 10, 2018
@jaymode
Copy link
Member

jaymode commented Dec 10, 2018

@albertzaharovits I labeled this one as a bug and think we should backport it for 6.5.x

@albertzaharovits albertzaharovits merged commit 01afeff into elastic:master Dec 10, 2018
@albertzaharovits albertzaharovits deleted the nit_connection_audit_events branch December 10, 2018 19:54
albertzaharovits added a commit that referenced this pull request Dec 10, 2018
The `origin.type` field's permitted values are now `rest` or
`transport` (as the docs declare) instead of `ip_filter`.
albertzaharovits added a commit that referenced this pull request Dec 10, 2018
The `origin.type` field's permitted values are now `rest` or
`transport` (as the docs declare) instead of `ip_filter`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants