CCR: mention how to enable soft deletes in error message when not enabled #36476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bleskes
added
>non-issue
v7.0.0
:Distributed/CCR
|
Pinging @elastic/es-distributed |
martijnvg
approved these changes
Dec 11, 2018
|
Thanks @martijnvg, I was optimistically relying on CI to be bubble up tests that rely on this string (if at all). Thanks for the heads up. |
jasontedor
requested changes
Dec 11, 2018
| @@ -124,7 +124,8 @@ private void createFollowerIndex( | |||
| } | |||
| if (leaderIndexMetaData.getSettings().getAsBoolean(IndexSettings.INDEX_SOFT_DELETES_SETTING.getKey(), false) == false) { | |||
| listener.onFailure( | |||
| new IllegalArgumentException("leader index [" + request.getLeaderIndex() + "] does not have soft deletes enabled")); | |||
| new IllegalArgumentException("leader index [" + request.getLeaderIndex() + "] does not have soft deletes enabled." + | |||
| "soft deletes must be enabled when the index is created by setting index.soft_deletes.enabled to true")); | |||
There was a problem hiding this comment.
Please use IndexSettings.INDEX_SOFT_DELETES_SETTING.getKey() so we have fewer places we have to search the code base for the hard string for, if ever we need to.
There was a problem hiding this comment.
doh. Should have done this from the get go.
jasontedor
approved these changes
Dec 11, 2018
bleskes
changed the title
bleskes
force-pushed
the
ccr_soft_delete_not_enabled_error
branch
from
c520ed1
to
a3af273
Compare
|
check this please |
|
@martijnvg @jasontedor FYI - I rebased this against 6.x . With the merge of #36141 which enables soft deletes as a default, I don't think this makes sense for master any more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.