SETTINGS: Correctly Identify Noop Updates #36560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
original-brownbear
commented
Dec 12, 2018
original-brownbear
commented
- We should compare the target value with the to be applied value before interpreting the update as a change
- This speeds up the test failing in Netty4HttpRequestSizeLimitIT testDoesNotLimitExcludedRequests fails reproducibly #36496 considerably by preventing state updates on noop setting updates
* We should compare the target value with the to be applied value before interpreting the update as a change * This speeds up the test failing in elastic#36496 considerably by preventing state updates on noop setting updates
original-brownbear
added
>bug
:Core/Infra/Settings
|
Pinging @elastic/es-core-infra |
|
@elasticmachine retest this please |
|
@danielmitterdorfer thanks! |
original-brownbear
added a commit
that referenced
this pull request
Dec 13, 2018
* We should compare the target value with the to be applied value before interpreting the update as a change * This speeds up the test failing in #36496 considerably by preventing state updates on noop setting updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.