Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQL: Fix issue with complex HAVING and GROUP BY ordinal #36594

Merged
merged 4 commits into from Dec 17, 2018
Merged

SQL: Fix issue with complex HAVING and GROUP BY ordinal #36594

merged 4 commits into from Dec 17, 2018

Commits on Dec 13, 2018

  1. SQL: Fix issue with complex HAVING and GROUP BY ordinal 

    When trying to analyze a HAVING condition, we crate a temp Aggregate
Plan which wasn't created correctly (missing the expressions from the
SELECT clause) and as a result the ordinal (1, 2, etc) in the GROUP BY
couldn't be resolved correctly.

Also after successfully analyzing the HAVING condition, still the
original plan was returned.

Fixes: elastic#36059
    @matriv
    matriv committed Dec 13, 2018
    Copy the full SHA
    0928adc View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2018

  1. Merge remote-tracking branch 'upstream/master' into mt/fix-36059

    @matriv
    matriv committed Dec 14, 2018
    Copy the full SHA
    046db85 View commit details
    Browse the repository at this point in the history

  2. Address comment

    @matriv
    matriv committed Dec 14, 2018
    Copy the full SHA
    5832996 View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2018

  1. Address comment

    @matriv
    matriv committed Dec 17, 2018
    Copy the full SHA
    e2005d1 View commit details
    Browse the repository at this point in the history