SQL: Fix MOD() for long and integer arguments #36599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, Math.floorMod was used for integers and longs which has different logic for negative numbers. Also, the priority of data types check was wrong as if one of the args is double the evaluation should be with doubles, then for floats, then longs and finally integers. Fixes: elastic#36364
|
Pinging @elastic/es-search |
costin
approved these changes
Dec 13, 2018
|
@costin you get a warning for them in the IDE, since there is no signature requiring this and doesn't change anything in the behaviour of junit. |
matriv
added a commit
that referenced
this pull request
Dec 13, 2018
Previously, Math.floorMod was used for integers and longs which has different logic for negative numbers. Also, the priority of data types check was wrong as if one of the args is double the evaluation should be with doubles, then for floats, then longs and finally integers. Fixes: #36364
|
Backported to |
matriv
added a commit
that referenced
this pull request
Dec 13, 2018
Previously, Math.floorMod was used for integers and longs which has different logic for negative numbers. Also, the priority of data types check was wrong as if one of the args is double the evaluation should be with doubles, then for floats, then longs and finally integers. Fixes: #36364
|
Backported to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, Math.floorMod was used for integers and longs
which has different logic for negative numbers. Also, the
priority of data types check was wrong as if one of the args
is double the evaluation should be with doubles, then for floats,
then longs and finally integers.
Fixes: #36364