SQL: Fix translation to painless for conditionals #36636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing `formatTemplate()` for conditional functions which resulted in incomplete painless script. Moreover the specific return type of Object in the painless signatures resulted in casting exceptions when conditional functions are used in the ORDER BY. Fixes: elastic#36631
|
Pinging @elastic/es-search |
matriv
added a commit
that referenced
this pull request
Dec 14, 2018
Add missing `formatTemplate()` for conditional functions which resulted in incomplete painless script. Moreover the specific return type of Object in the painless signatures resulted in casting exceptions when conditional functions are used in the ORDER BY. Fixes: #36631
|
Backported to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing
formatTemplate()for conditional functions whichresulted in incomplete painless script. Moreover the specific
return type of Object in the painless signatures resulted in
casting exceptions when conditional functions are used in the
ORDER BY.
Fixes: #36631