SQL: Scripting support for casting functions CAST and CONVERT #36640
Conversation
|
Pinging @elastic/es-search |
|
run the gradle build tests 2 |
| // Casting | ||
| // | ||
| public static Object convert(Object value, String typeName) { | ||
| if (value == null) { |
There was a problem hiding this comment.
I think it's unnecessary, it's done internally in convert()
| # | ||
| # Casting | ||
| # | ||
| def convert(Object, String) |
There was a problem hiding this comment.
I have a slight preference to name it cast which is the main name for SQL, but convert is also good.
| @@ -74,6 +78,18 @@ protected Processor makeProcessor() { | |||
| return new CastProcessor(DataTypeConversion.conversionFor(from(), to())); | |||
| } | |||
|
|
|||
| @Override | |||
| public ScriptTemplate asScript() { | |||
| ScriptTemplate fieldAsScript = asScript(field()); | |||
There was a problem hiding this comment.
Since the solution is to use a slightly different script, simply override processScript (see its implementations for examples like MathFunction). This way you only need to define the string and not worry about the boiler-plate around passing the script further.
There was a problem hiding this comment.
With processScript we cannot set the dataType as parameter and we are forced to send it as String inline. Will leave it as is at the moment, as discussed.
| # | ||
| # Casting | ||
| # | ||
| def convert(Object, String) |
|
@astefan then let's go ahead and merge this and check afterwards the HAVING case. |
|
closes #34557 |
This PR fixes #36061. Up until this point, there was no scripting support for CAST and CONVERT and, as such, CAST and CONVERT cannot be used in GROUP BY and ORDER BY expressions (where Painless scripting is used).