Fix Rollup's metadata parser #36791
Merged
Fix Rollup's metadata parser #36791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The parser used for rollup configs in _meta fields was not able to handle unrelated data in the meta field. If an unrelated object was encountered, it would half-consume the JSON object, realize it wasn'ta rollup config, then stop parsing. This would leave the object halfway consumed and the parsing framework would throw an exception. This commit replaces the parsing logic with a set of minimal parsers, each for the specific component we care about (`_doc`, `_meta`, `_rollup`) and configured to ignore unknown fields where applicable. Not quite as clean, but less hacky than before and more robust. Also adds tests (randomized and explicit) to make sure this doesn't break in the future.
polyfractal
added
>bug
v7.0.0
:StorageEngine/Rollup
|
Pinging @elastic/es-analytics-geo |
colings86
approved these changes
Dec 18, 2018
polyfractal
added a commit
that referenced
this pull request
Dec 18, 2018
The parser used for rollup configs in _meta fields was not able to handle unrelated data in the meta field. If an unrelated object was encountered, it would half-consume the JSON object, realize it wasn'ta rollup config, then stop parsing. This would leave the object halfway consumed and the parsing framework would throw an exception. This commit replaces the parsing logic with a set of minimal parsers, each for the specific component we care about (`_doc`, `_meta`, `_rollup`) and configured to ignore unknown fields where applicable. More verbose, but less hacky than before and should be more robust. Also adds tests (randomized and explicit) to make sure this doesn't break in the future.
polyfractal
added a commit
that referenced
this pull request
Dec 18, 2018
The parser used for rollup configs in _meta fields was not able to handle unrelated data in the meta field. If an unrelated object was encountered, it would half-consume the JSON object, realize it wasn'ta rollup config, then stop parsing. This would leave the object halfway consumed and the parsing framework would throw an exception. This commit replaces the parsing logic with a set of minimal parsers, each for the specific component we care about (`_doc`, `_meta`, `_rollup`) and configured to ignore unknown fields where applicable. More verbose, but less hacky than before and should be more robust. Also adds tests (randomized and explicit) to make sure this doesn't break in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parser used for rollup configs in _meta fields was not able to handle unrelated data in the meta field. If an unrelated object was encountered, it would half-consume the JSON object, realize it wasn't a rollup config, then stop parsing. This would leave the object halfway consumed and the parsing framework would throw an exception.
This commit replaces the parsing logic with a set of minimal static parsers, each for the specific component we care about (
_doc,_meta,_rollup) and configured to ignore unknown fields where applicable.More verbose, but less hacky than before and should be more robust.
Also adds tests (randomized and explicit) to make sure this doesn't break in the future.
Closes #36726