[GEO] Fork Lucene's LatLonShape Classes to local lucene package

[nknize]

Lucene 7.6 uses a smaller encoding for LatLonShape. This commit forks the LatLonShape classes to Elasticsearch's local lucene package. These classes will be removed on the release of Lucene 7.6.

[elasticmachine]

Pinging @elastic/es-analytics-geo

[nknize]

@imotov having some issues w/ sql-cli and LatLonShape forbiddenAPI signatures. Would you mind having a look?

[jpountz]

This might be more a build issue than a sql-cli issue. It looks like the forbidden APIs in es-server-signatures.txt are applied to all modules rather than just the server module like the name suggests, which turns out to be an issue for modules that don't depend on lucene-sandbox where LatLonShape lives. Maybe the best way to proceed in the short term is to have a dedicated signatures file for these classes that live in sandbox and add them only in the Gradle build file for the server module (see eg. how rest-high-level-client specific signatures are added in client/rest-high-level/build.gradle)? @atorok Any opinion?

[imotov]

@nknize found it. Running the rest of precommit to make sure it didn't break anything else and then will push the changes.

[jpountz]

I'm good with Igor's workaround.

[imotov]

LGTM2

[nknize]

Excellent... as soon as CI comes back (hopefully succesfully) I will merge this to master. We'll let CI settle out overnight with these two big PRs and if all looks good tomorrow (and approvals are in), I'll merge #36743 and backport this to 6.6

[alpar-t]

@jpountz The reason we configure the server signatures is that it's possible for projects depending on server to use the APIs forbidden in server via transitive dependencies. We could however be smarter about it and only add those signature if the project actually depends on server. I'll send a PR to make this happen.

[iverase]

I run the command ./gradlew assemble and got the following error:

> Task :server:javadoc
/Users/ivera/forks/elasticsearch-fork/server/src/main/java/org/apache/lucene/geo/XRectangle2D.java:41: error: unknown tag: lucene.internal
 * @lucene.internal
   ^
/Users/ivera/forks/elasticsearch-fork/server/src/main/java/org/apache/lucene/geo/XTessellator.java:67: error: unknown tag: lucene.experimental
 * @lucene.experimental
   ^
/Users/ivera/forks/elasticsearch-fork/server/src/main/java/org/apache/lucene/document/XLatLonShape.java:55: error: unknown tag: lucene.experimental
 * @lucene.experimental
   ^
3 errors

> Task :server:javadoc FAILED

Removing the Lucene tags remove the problem.