SQL: protocol returns ISO 8601 String formatted dates instead of Long for JDBC/ODBC requests #36800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
of JDBC/ODBC, to ISO 8601 with millis String.
|
Pinging @elastic/es-search |
|
@elasticmachine run default distro tests |
costin
approved these changes
Dec 19, 2018
| @@ -20,6 +23,8 @@ | |||
| public static final String SQL_TRACE = "org.elasticsearch.xpack.sql:TRACE"; | |||
|
|
|||
| public static final String JDBC_TIMEZONE = "timezone"; | |||
|
|
|||
| public static ZoneId UTC = ZoneId.of("Z"); | |||
There was a problem hiding this comment.
Any reason why org.es.xpack.sql.util.DateUtils is not used instead?
There was a problem hiding this comment.
It is not visible in the jdbc project.
| import static java.time.temporal.ChronoField.MINUTE_OF_HOUR; | ||
| import static java.time.temporal.ChronoField.SECOND_OF_MINUTE; | ||
|
|
||
| final class DateUtils { |
There was a problem hiding this comment.
Rename this to JdbcDateUtils to avoid name clashes with the class in the server.
Also add a comment on why this class is here (lack of visibility) since several things from there can be found here.
matriv
approved these changes
Dec 19, 2018
| import static java.time.temporal.ChronoField.MINUTE_OF_HOUR; | ||
| import static java.time.temporal.ChronoField.SECOND_OF_MINUTE; | ||
|
|
||
| final class DateUtils { |
| if (val == null) { | ||
| return null; | ||
| } | ||
| return DateUtils.asDateTimeField(val, DateUtils::asMillisSinceEpoch, (longValue) -> longValue); |
There was a problem hiding this comment.
just FYI, you can use Function.identity() for t->t cases
|
run the gradle build tests 1 |
1 similar comment
|
run the gradle build tests 1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the protocol for JDBC/ODBC requests in case of date columns, returning their values as
StringforZonedDateTimetype of date fields. This changes the current behavior of returninglongvalues representing UTC millis since epoch.There are still some situations (Histograms) where the returned value is not a
ZonedDateTimeinstance, but aLongrepresenting UTC millis since epoch. For those cases, the behavior remained unchanged.This addresses #36756.