New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle Null in FetchSourceContext#fetchSource #36839
Conversation
This change ensures that when null is passed as the value to one of its Nullable parameters, it is not wrapped in a String array. That would in turn cause a NPE when attempting to serialize FetchSourceContext as its constructor checks for null values only. In master, the problematic behavior was corrected as part of elastic#29293
Pinging @elastic/es-core-features |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@elasticmachine please run the gradle build tests 2 once more as the first time the worker ran out of memory 🐼 |
@elasticmachine please run the gradle build tests 2, hopefully for the last time |
Unstable network is unstable
@elasticmachine please run the gradle build tests 2 |
This change ensures that when null is passed as the value to one of UpdateRequest#fetchSource @nullable parameters, it is not wrapped in a String array. That would in turn cause a NPE when attempting to serialize FetchSourceContext as its constructor checks explicitly for Null and not for arrays of Null objects. In master, the problematic behavior was corrected as part of #29293
This change ensures that when null is passed as the value to one of UpdateRequest#fetchSource @nullable parameters, it is not wrapped in a String array. That would in turn cause a NPE when attempting to serialize FetchSourceContext as its constructor checks explicitly for Null and not for arrays of Null objects. In master, the problematic behavior was corrected as part of #29293
This change ensures that when null is passed as the value to one of
UpdateRequest#fetchSource
@Nullable
parameters, it is not wrapped in aString array. That would in turn cause a NPE when attempting to serialize
FetchSourceContext as its constructor checks explicitly for Null and not for
arrays of Null objects.
In master, the problematic behavior was corrected as part of #29293