Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the document create endpoint. #36863

Merged
merged 1 commit into from
Dec 19, 2018

Conversation

jtibshirani
Copy link
Contributor

The following updates were made:

  • Introduce the endpoint {index}/_create/{id} to replace {index}/{type}/{id}/_create.
  • Add deprecation warnings to RestIndexAction, plus tests in RestIndexActionTests.
  • For each REST yml test, create one version without types, and another legacy version that retains types (called *_with_types.yml).
  • Update HLRC request conversion to use the new endpoint when no type is provided. No updates were made to HLRC requests and responses, because this API reuses IndexRequest/ IndexResponse.

@jtibshirani jtibshirani added :Search Foundations/Mapping Index mappings, including merging and defining field types >deprecation v7.0.0 labels Dec 19, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search

Copy link
Contributor

@mayya-sharipova mayya-sharipova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jtibshirani Thanks Julie, nice work!

@jtibshirani jtibshirani merged commit ecb822c into elastic:master Dec 19, 2018
@jtibshirani jtibshirani deleted the deprecate-types-in-create branch December 19, 2018 23:20
@jimczi jimczi added v7.0.0-beta1 and removed v7.0.0 labels Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>deprecation :Search Foundations/Mapping Index mappings, including merging and defining field types v7.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants