Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate reference to _type in lookup queries #37016

Merged
merged 16 commits into from
Jan 9, 2019
Merged

Deprecate reference to _type in lookup queries #37016

merged 16 commits into from
Jan 9, 2019

Commits on Jan 4, 2019

  1. Deprecate reference to _type in lookup queries 

    Relates to elastic#35190
    @mayya-sharipova @jtibshirani
    mayya-sharipova authored and jtibshirani committed Jan 4, 2019
    Configuration menu
    Copy the full SHA
    8e892f5 View commit details
    Browse the repository at this point in the history

  2. Some additional refactors and bug fixes. 

    * Add integration test coverage for typeless lookup queries.
* Fix a bug around typeless terms lookup queries.
* Make sure to provide non-deprecated methods in QueryBuilders.
* Make the deprecation messages more accurate.
* Update the query DSL documentation.
* Avoid creating duplicate query builder tests.

Don't use 'ids' when generating random queries to avoid types warnings.
    @jtibshirani
    jtibshirani committed Jan 4, 2019
    Configuration menu
    Copy the full SHA
    d7b0cd8 View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2019

  1. Add Javadoc to deprecated methods to suggest alternatives.

    @jtibshirani
    jtibshirani committed Jan 7, 2019
    Configuration menu
    Copy the full SHA
    986930e View commit details
    Browse the repository at this point in the history

  2. Switch back to using an ids query in RandomQueryBuilder.

    @jtibshirani
    jtibshirani committed Jan 7, 2019
    Configuration menu
    Copy the full SHA
    96370d7 View commit details
    Browse the repository at this point in the history

  3. Avoid introducing a special case in TermsLookup#hashCode.

    @jtibshirani
    jtibshirani committed Jan 7, 2019
    Configuration menu
    Copy the full SHA
    932e250 View commit details
    Browse the repository at this point in the history

  4. Add some clarifying comments.

    @jtibshirani
    jtibshirani committed Jan 7, 2019
    Configuration menu
    Copy the full SHA
    6678b83 View commit details
    Browse the repository at this point in the history

  5. Prefer to use Strings.EMPTY_ARRAY.

    @jtibshirani
    jtibshirani committed Jan 7, 2019
    Configuration menu
    Copy the full SHA
    e176101 View commit details
    Browse the repository at this point in the history

  6. Give a clear error message when typeless terms lookup queries are use… 

    …d with pre-7.0 nodes.
    @jtibshirani
    jtibshirani committed Jan 7, 2019
    Configuration menu
    Copy the full SHA
    7a6100a View commit details
    Browse the repository at this point in the history

  7. Minor spacing issue.

    @jtibshirani
    jtibshirani committed Jan 7, 2019
    Configuration menu
    Copy the full SHA
    12f5eaf View commit details
    Browse the repository at this point in the history

  8. Test terms lookup serialization to 6.x nodes.

    @jtibshirani
    jtibshirani committed Jan 7, 2019
    Configuration menu
    Copy the full SHA
    f3031ba View commit details
    Browse the repository at this point in the history

  9. Make sure GeoShapeQueryBuilderTests covers typeless queries.

    @jtibshirani
    jtibshirani committed Jan 7, 2019
    Configuration menu
    Copy the full SHA
    c9f48a3 View commit details
    Browse the repository at this point in the history

  10. Simplify the handling around null types for more_like_this queries.

    @jtibshirani
    jtibshirani committed Jan 7, 2019
    Configuration menu
    Copy the full SHA
    806e957 View commit details
    Browse the repository at this point in the history

  11. Merge remote-tracking branch 'upstream/master' into deprecate-types-i… 

    …n-lookup-queries
    @jtibshirani
    jtibshirani committed Jan 7, 2019
    Configuration menu
    Copy the full SHA
    8324f5f View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2019

  1. Small refactors in response to review comments.

    @jtibshirani
    jtibshirani committed Jan 8, 2019
    Configuration menu
    Copy the full SHA
    13c4854 View commit details
    Browse the repository at this point in the history

  2. Fix an outdated message in GeoShapeQueryBuilderTests.

    @jtibshirani
    jtibshirani committed Jan 8, 2019
    Configuration menu
    Copy the full SHA
    0bdbd71 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/master' into deprecate-types-i… 

    …n-lookup-queries
    @jtibshirani
    jtibshirani committed Jan 8, 2019
    Configuration menu
    Copy the full SHA
    61ad78d View commit details
    Browse the repository at this point in the history