Make sure to accept empty unnested mappings in create index requests. #37089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtibshirani
added
>bug
:Search/Mapping
|
Pinging @elastic/es-search |
jtibshirani
commented
Jan 2, 2019
| @@ -97,17 +97,6 @@ public void testIndexTemplateWithAliasNameEqualToTemplatePattern() { | |||
| assertThat(errors.get(0).getMessage(), equalTo("Alias [foobar] cannot be the same as any pattern in [foo, foobar]")); | |||
| } | |||
|
|
|||
| public void testIndexTemplateWithValidateEmptyMapping() throws Exception { | |||
There was a problem hiding this comment.
It looks like these tests were added in fd76291, not to guard against a particular bug, but as a means of checking whether index templates were being validated.
|
@elasticmachine run gradle build tests 2 |
jpountz
approved these changes
Jan 3, 2019
jtibshirani
added a commit
that referenced
this pull request
Jan 3, 2019
jtibshirani
added a commit
that referenced
this pull request
Jan 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in
DocumentMapperParserwhere empty mappings were rejected unless they were keyed by a type name. It's part of a larger effort to allow for typeless index creation requests.In index creation requests, we at one point tried to maintain the invariant that all mapping values in the request were nested under the type name. It looks like this bug arose in 2341825 when we made it no longer necessary that mappings be nested under a type name. That commit made it possible to handle non-nested mappings, but did not properly update the initial check for an empty map.