Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable a configurable delay for shutdown when calling killproc. #3719

Closed
wants to merge 1 commit into from
Closed

Enable a configurable delay for shutdown when calling killproc. #3719

wants to merge 1 commit into from

Conversation

tmclaugh
Copy link

Useful as soem nodes may take longer than others.

@tmclaugh
Copy link
Author

Not sure if this should be even longer. killproc() on RHEL calls checkpid, sleeps for a second, and then sleeps for the delay before calling checkpid a third time.

@ghost ghost assigned spinscale Sep 18, 2013
@spinscale
Copy link
Contributor

Nice catch. Thanks!

What do you consider a useful default here from your experience?

@tmclaugh
Copy link
Author

That I'm not exactly sure. This is the first time I know of that we've
run into it. Default if no delay is passed to killproc() is 3 which
results in a 4 second total wait. Her QA cluster wasn't that busy
yesterday so they were no help and I'm sure she doesn't want me knocking
out her production cluster. :) I added the sysconfig value to make it
easy to change via Puppet.

On 09/18/2013 02:48 AM, Alexander Reelsen wrote:

Nice catch. Thanks!

What do you consider a useful default here from your experience?

—
Reply to this email directly or view it on GitHub
#3719 (comment).

@spinscale spinscale mentioned this pull request Oct 25, 2013
Closed
spinscale added a commit to spinscale/elasticsearch that referenced this pull request Aug 22, 2014
@spinscale
Add ES_STOP_TIMEOUT/ES_KILL_TIMEOUT variables to packages
c8bcbef 
This variable allows to configure the waiting time after a TERM signal has
been sent. After that waiting time a KILL signal is sent to ensure the
service is stopped.

In case of a bigger installation the default values might be to slow, so it
now is configurable.

Also, we opted out from sending a KILL signal by default. This has to be
explicitely done by using the ES_KILL_TIMEOUT variable.

Original work done by @tmclaugh at the PR elastic#3719

Closes elastic#3719
Closes elastic#3972
@tmclaugh
Copy link
Author

Unnecessary via #3973

(nothingtodohere)

@clintongormley
Copy link

@tmclaugh does your last comment we should close this?

@tmclaugh
Copy link
Author

I closed this since it appears the work went forward in #3973

spinscale added a commit to spinscale/elasticsearch that referenced this pull request Sep 8, 2014
@spinscale
Add ES_STOP_TIMEOUT/ES_KILL_TIMEOUT variables to packages
cd395a8 
This variable allows to configure the waiting time after a TERM signal has
been sent. After that waiting time a KILL signal is sent to ensure the
service is stopped.

In case of a bigger installation the default values might be to slow, so it
now is configurable.

Also, we opted out from sending a KILL signal by default. This has to be
explicitely done by using the ES_KILL_TIMEOUT variable.

Original work done by @tmclaugh at the PR elastic#3719

Closes elastic#3719
Closes elastic#3972
@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@spinscale spinscale

Labels
:Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts Team:Delivery Meta label for Delivery team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tmclaugh @spinscale @clintongormley @mark-vieira