Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Sequence number powered OCC for processing updates #37308

Merged
merged 1 commit into from Jan 11, 2019

Conversation

bleskes
Copy link
Contributor

@bleskes bleskes commented Jan 10, 2019

Updates perform realtime get, perform the requested update and then index the document again using optimistic concurrency control. This PR changes the logic to use sequence numbers instead of versioning.

Note that the current versioning logic isn't suffering from the same problem as external OCC requests because the get and indexing is always done on the same primary.

Relates #36148
Relates #10708

@bleskes bleskes added >enhancement :Distributed/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. v7.0.0 v6.7.0 labels Jan 10, 2019
@bleskes bleskes requested a review from ywelsch January 10, 2019 15:05
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

Copy link
Contributor

@ywelsch ywelsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bleskes bleskes merged commit d21df2a into elastic:master Jan 11, 2019
@bleskes bleskes deleted the cas_update branch January 11, 2019 14:24
bleskes added a commit that referenced this pull request Jan 11, 2019
Updates perform realtime get, perform the requested update and then index the document again
using optimistic concurrency control. This PR changes the logic to use sequence numbers instead
of versioning.

Note that the current versioning logic isn't suffering from the same problem as external OCC
requests because the get and indexing is always done on the same primary.

Relates #36148
Relates #10708
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. >enhancement v6.7.0 v7.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants