Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Sequence number powered OCC for processing updates #37308

Merged
merged 1 commit into from Jan 11, 2019

Conversation

Projects
None yet
4 participants
@bleskes
Copy link
Member

commented Jan 10, 2019

Updates perform realtime get, perform the requested update and then index the document again using optimistic concurrency control. This PR changes the logic to use sequence numbers instead of versioning.

Note that the current versioning logic isn't suffering from the same problem as external OCC requests because the get and indexing is always done on the same primary.

Relates #36148
Relates #10708

@elasticmachine

This comment has been minimized.

Copy link

commented Jan 10, 2019

@ywelsch
Copy link
Contributor

left a comment

LGTM

@bleskes bleskes merged commit d21df2a into elastic:master Jan 11, 2019

7 checks passed

CLA Commit author is a member of Elasticsearch
Details
elasticsearch-ci-1 Build finished.
Details
elasticsearch-ci-2 Build finished.
Details
elasticsearch-ci/default-distro Build finished.
Details
elasticsearch-ci/docbldesx Build finished.
Details
elasticsearch-ci/oss-distro-docs Build finished.
Details
elasticsearch-ci/packaging-sample Build finished.
Details

@bleskes bleskes deleted the bleskes:cas_update branch Jan 11, 2019

bleskes added a commit that referenced this pull request Jan 11, 2019

Use Sequence number powered OCC for processing updates (#37308)
Updates perform realtime get, perform the requested update and then index the document again
using optimistic concurrency control. This PR changes the logic to use sequence numbers instead
of versioning.

Note that the current versioning logic isn't suffering from the same problem as external OCC
requests because the get and indexing is always done on the same primary.

Relates #36148
Relates #10708

@colings86 colings86 added v7.0.0-beta1 and removed v7.0.0 labels Feb 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.