Testing conventions now checks for tests in main #37321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the last outstanding feature of the old NamingConventionsTask, so time to remove it.
alpar-t
added
>non-issue
:Delivery/Build
|
Pinging @elastic/es-core-infra |
rjernst
approved these changes
Jan 23, 2019
| // some test projects don't have a main source set | ||
| return Collections.emptySet(); | ||
| } | ||
| return Boilerplate.getJavaSourceSets(getProject()).getByName(SourceSet.MAIN_SOURCE_SET_NAME) |
There was a problem hiding this comment.
no need to re-get the source set, you already have it above to use?
alpar-t
commented
Jan 23, 2019
| checkNoneExists( | ||
| "Classes matching the test naming convention should be in test not main", | ||
| getMainClassNames().stream() | ||
| .filter(this::implementsNamingConvention) |
There was a problem hiding this comment.
this could be moved to the input property getter
alpar-t
added a commit
that referenced
this pull request
Jan 24, 2019
* Testing conventions now checks for tests in main This is the last outstanding feature of the old NamingConventionsTask, so time to remove it. * PR review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last outstanding feature of the old
NamingConventionsTask, so time to remove it.