Security Audit includes HTTP method for requests #37322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertzaharovits
added
>enhancement
v7.0.0
:Security/Audit
|
Pinging @elastic/es-security |
|
@ycombinator , does merging this require tweaking in elastic/beats#8852 ? |
albertzaharovits
added a commit
that referenced
this pull request
Jan 13, 2019
Adds another field, named "request.method", to the structured logfile audit. This field is present for all events associated with a REST request (not a transport request) and the value is one of GET, POST, PUT, DELETE, OPTIONS, HEAD, PATCH, TRACE and CONNECT.
|
Thanks for the ping here @albertzaharovits. Short answer: Yes, Filebeat will want to make sure it parses and indexes this new field as well. Longer answer, more as an FYI: I'm thinking of completely overhauling elastic/beats#8852 as I'm not sure the current approach is right (see elastic/beats#8852 (comment)). Depending on where this lands, adding new fields to the structured log may or may not need changes on the Filebeat going forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds another field ("request.method") to the structured logfile audit. This field is present for all events associated with a REST request (not a transport request) and the value is one of GET, POST, PUT, DELETE, OPTIONS, HEAD, PATCH, TRACE and CONNECT.
Closes #29765