Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Types removal - deprecate include_type_name with index templates #37484

Merged
merged 16 commits into from
Jan 29, 2019

Commits on Jan 29, 2019

  1. Added deprecation warnings for use of include_type_name in put/get in…

    …dex templates.
    
    Made changes to PutIndexTemplateRequest to accept typeless mappings.
    HLRC changes:
    GetIndexTemplateRequest has a new client-side class which is a copy of server's GetIndexTemplateResponse but modififed to use more client-friendly MappingMetaData rather than CompressedXContent and does not require a typename to access the content from a map.
    This change necessitated a new method name on IndicesClient so deprecated getTemplate and added getIndexTemplate.
    PutIndexTemplateRequest has a new client-side class which doesn't use types in the mappings
    Fix test failure
    markharwood committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    b93c66d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7a3ee63 View commit details
    Browse the repository at this point in the history
  3. Compilation issue

    markharwood committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    2668570 View commit details
    Browse the repository at this point in the history
  4. Javadoc issue

    markharwood committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    b67672b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    1105177 View commit details
    Browse the repository at this point in the history
  6. Unused import

    markharwood committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    9ec52a3 View commit details
    Browse the repository at this point in the history
  7. Stripped HLRC version of PutIndexTemplateRequest of all references to…

    … type - the server-side version of PITR provides the api for typed templates
    markharwood committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    64ae784 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    56381a9 View commit details
    Browse the repository at this point in the history
  9. Unused imports

    markharwood committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    9823346 View commit details
    Browse the repository at this point in the history
  10. Unused imports

    markharwood committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    b1615f2 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    2fb874b View commit details
    Browse the repository at this point in the history
  12. Checkstyle fix

    markharwood committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    5f08782 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    1240b2e View commit details
    Browse the repository at this point in the history
  14. Addressing review comments:

    Validate null template name in constructor.
    Use server side’s GetIndexTemplateResponse class to create XContent for client-side counterpart’s fromXContent test.
    markharwood committed Jan 29, 2019
    Configuration menu
    Copy the full SHA
    925c064 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    a0326e4 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    aebbc9b View commit details
    Browse the repository at this point in the history