Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove more include_type_name and types from docs #37601

Merged
merged 2 commits into from Jan 18, 2019

Conversation

cbuescher
Copy link
Member

@cbuescher cbuescher commented Jan 18, 2019

Follow up to #37568.

Use of ?include_type_name=true in docs on index creation down to ~120.

@cbuescher cbuescher added >docs General docs changes :Search/Mapping Index mappings, including merging and defining field types v7.0.0 >refactoring labels Jan 18, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search

Copy link
Contributor

@markharwood markharwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment otherwise LGTM

<3> Specify fields or _properties_.
<4> Specify the data `type` and mapping for each field.
<2> Specify fields or _properties_.
<3> Specify the data `type` and mapping for each field.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No docs for item 4

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

callout <4> was deleted (actually <2> was deleted and everything else moved up)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected the remaining offenting <4> Callout

@cbuescher
Copy link
Member Author

@elasticmachine test this please

@cbuescher cbuescher merged commit 3a96608 into elastic:master Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes >refactoring :Search/Mapping Index mappings, including merging and defining field types v7.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants