Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SyncedFlushService.getShardRoutingTable() should use metadata to check for index existence #37691

Merged
merged 1 commit into from Jan 23, 2019

Conversation

Projects
None yet
4 participants
@tlrx
Copy link
Member

commented Jan 22, 2019

The method SyncedFlushService.getShardRoutingTable() checks the existence of a routing table to determine if the index to synced flush exists or not, and then it uses the index metadata to determine if the index is closed. It think it should instead check the existence of the index meta data upfront; if there are no metadata then the index does not exist. It can then check if the index is closed using the metadata.

This pull request changes the behavior of the getShardRoutingTable() to use index metadata first, and also resolves index routing table using the full index name + uuid. This change will also make this method more compliant with the replication of closed indices in which closed indices will have a routing table. It does not change the behavior of the existing method.

Related #33888

@elasticmachine

This comment has been minimized.

Copy link

commented Jan 22, 2019

@tlrx tlrx referenced this pull request Jan 22, 2019

Closed

Replicate closed indices #33888

50 of 50 tasks complete
@ywelsch
Copy link
Contributor

left a comment

LGTM

@tlrx

This comment has been minimized.

Copy link
Member Author

commented Jan 22, 2019

@elasticmachine run elasticsearch-ci/default-distro

@tlrx tlrx merged commit 6130d15 into elastic:master Jan 23, 2019

7 checks passed

CLA Commit author is a member of Elasticsearch
Details
elasticsearch-ci/1 Build finished.
Details
elasticsearch-ci/2 Build finished.
Details
elasticsearch-ci/default-distro Build finished.
Details
elasticsearch-ci/docbldesx Build finished.
Details
elasticsearch-ci/oss-distro-docs Build finished.
Details
elasticsearch-ci/packaging-sample Build finished.
Details

@tlrx tlrx deleted the tlrx:adapt-syncflushservice branch Jan 23, 2019

tlrx added a commit that referenced this pull request Jan 23, 2019

jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Jan 23, 2019

Merge remote-tracking branch 'elastic/master' into optimize-warning-h…
…ead-de-duplication

* elastic/master: (24 commits)
  [TEST] Mute MlMappingsUpgradeIT testMappingsUpgrade
  Streamline skip_unavailable handling (elastic#37672)
  Only bootstrap and elect node in current voting configuration (elastic#37712)
  Ensure either success or failure path for SearchOperationListener is called (elastic#37467)
  Target only specific index in update settings test
  Add a note how to benchmark Elasticsearch
  Don't use Groovy's `withDefault` (elastic#37726)
  Adapt SyncedFlushService (elastic#37691)
  Mute FilterAggregatorTests#testRandom
  Switch mapping/aggregations over to java time (elastic#36363)
  [ML] Update ML results mappings on process start (elastic#37706)
  Modify removal_of_types.asciidoc (elastic#37648)
  Fix edge case in PutMappingRequestTests (elastic#37665)
  Use new bulk API endpoint in the docs (elastic#37698)
  Expose sequence number and primary terms in search responses (elastic#37639)
  Remove LicenseServiceClusterNotRecoveredTests (elastic#37528)
  Migrate SpecificMasterNodesIT to Zen2 (elastic#37532)
  Fix MetaStateFormat tests
  Use plain text instead of latexmath
  Fix a typo in a warning message in TestFixturesPlugin (elastic#37631)
  ...

@colings86 colings86 added v7.0.0-beta1 and removed v7.0.0 labels Feb 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.