Ground work to start up the docker image in the build #37754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds a docker compose configuration that's used with the `elasticsearch.test.fixtures` plugin to start up the image and check that the TCP ports are up. We can build on this to add other checks for culster health, run REST tests, etc. We can add multiple containers and configurations to the compose file (e.x. test different env vars) and form clusters.
alpar-t
added
>non-issue
:Delivery/Build
|
Pinging @elastic/es-core-infra |
rjernst
approved these changes
Jan 23, 2019
| @@ -0,0 +1,20 @@ | |||
| version: '3' | |||
There was a problem hiding this comment.
please add a comment that indicates this file is only used for testing of the docker image, not what we publish
alpar-t
added a commit
that referenced
this pull request
Jan 24, 2019
This change adds a docker compose configuration that's used with the `elasticsearch.test.fixtures` plugin to start up the image and check that the TCP ports are up. We can build on this to add other checks for culster health, run REST tests, etc. We can add multiple containers and configurations to the compose file (e.x. test different env vars) and form clusters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a docker compose configuration that's used with
the
elasticsearch.test.fixturesplugin to start up the imageand check that the TCP ports are up.
We can build on this to add other checks for cluster health,
run REST tests, etc.
We can add multiple containers and configurations to the compose
file (e.x. test different env vars) and form clusters.
To achieve this, the plugin was changed to allow a single Gradle project to host both the fixture and the tests that use it.
An added benefit is that docker based test fixtures have their images cached in CI images ( we do a compose pull when building this image ), so by using the same mechanism we also get to pull everything down for the docker images and will be able to reclaim some of the build time we lost when we added the docker image build.