-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SQL: Fix BasicFormatter NPE #37804
SQL: Fix BasicFormatter NPE #37804
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Left 2 comments about logging in tests.
+ "1953-09-02T00:00:00.000Z", result[2]); | ||
assertEquals("dog |1.7976931348623157E308|123124.888 |9912 |goat |" | ||
+ "2000-03-15T21:34:37.443Z", result[3]); | ||
logger.info(result[0]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need those?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't. Not paying attention. Thanks for catching.
x-pack/plugin/sql/src/test/java/org/elasticsearch/xpack/sql/action/BasicFormatterTests.java
Outdated
Show resolved
Hide resolved
…o fix_formatter_npe
@elasticmachine run elasticsearch-ci/1 |
(cherry picked from commit 163a27b)
Lacking tests for this made the bug go through and discovered by manual testing. This PR should fix the bug and, also, adds tests. Bug introduced with #37602