Expose minimum_master_nodes in cluster state #37811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To safely support rolling upgrades from 6.x to 7.x we need the 7.x nodes to have access to the `minimum_master_nodes` setting, but this setting is otherwise unnecessary in 7.x and we would like to remove it. Since a rolling upgrade from 6.x to 7.x involves the 7.x nodes joining a 6.x master, we can avoid the need for setting `minimum_master_nodes` on the 7.x nodes by copying the value set on the 6.x master. This change exposes the master's node-level value for `minimum_master_nodes` via a field in the cluster state.
DaveCTurner
added
>enhancement
blocker
:Distributed/Cluster Coordination
|
Pinging @elastic/es-distributed |
|
The parallel changes to |
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Jan 24, 2019
This completes the BWC serialisation changes required for a 6.7 master to inform other nodes of the node-level value of the `minimum_master_nodes` setting. Relates elastic#37701, elastic#37811
|
@elasticmachine please run elasticsearch-ci/2 |
1 similar comment
|
@elasticmachine please run elasticsearch-ci/2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To safely support rolling upgrades from 6.x to 7.x we need the 7.x nodes to
have access to the
minimum_master_nodessetting, but this setting isotherwise unnecessary in 7.x and we would like to remove it. Since a rolling
upgrade from 6.x to 7.x involves the 7.x nodes joining a 6.x master, we can
avoid the need for setting
minimum_master_nodeson the 7.x nodes by copyingthe value set on the 6.x master.
This change exposes the master's node-level value for
minimum_master_nodesvia a field in the cluster state.
Relates #37701