Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate HLRC security methods #37883

Merged

Conversation

Projects
None yet
4 participants
@hub-cap
Copy link
Contributor

commented Jan 25, 2019

This commit deprecates the few methods that had their parameters
reordered to facilitate the move from EmptyResponse to boolean. This
commit also readds the boolean based methods with the proper
signatures.

Relates #37540
Relates #36938

Deprecate HLRC security methods
This commit deprecates the few methods that had their parameters
reordered to facilitate the move from EmptyResponse to boolean. This
commit also readds the boolean based methods with the proper
signatures.

Relates #37540
Relates #36938
@elasticmachine

This comment has been minimized.

Copy link

commented Jan 25, 2019

@jakelandis jakelandis self-requested a review Jan 28, 2019

@hub-cap

This comment has been minimized.

Copy link
Contributor Author

commented Jan 28, 2019

@elasticmachine run elasticsearch-ci/2

@jakelandis
Copy link
Contributor

left a comment

A question and a minor change request (3 times).

*/
@Deprecated
public boolean enableUser(RequestOptions options, EnableUserRequest request) throws IOException {
return restHighLevelClient.performRequest(request, SecurityRequestConverters::enableUser, options,

This comment has been minimized.

Copy link
@jakelandis

jakelandis Jan 28, 2019

Contributor

Can you make this method delegate to the one that is not deprecated ?

*/
@Deprecated
public boolean disableUser(RequestOptions options, DisableUserRequest request) throws IOException {

This comment has been minimized.

Copy link
@jakelandis

jakelandis Jan 28, 2019

Contributor

Can you make this method delegate to the one that is not deprecated.

Show resolved Hide resolved ...st-high-level/src/main/java/org/elasticsearch/client/SecurityClient.java
*/
@Deprecated
public void changePasswordAsync(RequestOptions options, ChangePasswordRequest request,
ActionListener<Boolean> listener) {
restHighLevelClient.performRequestAsync(request, SecurityRequestConverters::changePassword, options,

This comment has been minimized.

Copy link
@jakelandis

jakelandis Jan 28, 2019

Contributor

Can you have this method delegate to the non-deprecated one.

hub-cap added some commits Jan 30, 2019

@jakelandis
Copy link
Contributor

left a comment

LGTM

@hub-cap hub-cap merged commit 66530db into elastic:master Feb 4, 2019

7 checks passed

CLA Commit author is a member of Elasticsearch
Details
elasticsearch-ci/1 Build finished.
Details
elasticsearch-ci/2 Build finished.
Details
elasticsearch-ci/default-distro Build finished.
Details
elasticsearch-ci/docbldesx Build finished.
Details
elasticsearch-ci/oss-distro-docs Build finished.
Details
elasticsearch-ci/packaging-sample Build finished.
Details

jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Feb 5, 2019

Merge remote-tracking branch 'elastic/master' into simplify-retention…
…-lease-expiration

* elastic/master: (24 commits)
  Add support for API keys to access Elasticsearch (elastic#38291)
  Add typless client side GetIndexRequest calls and response class (elastic#37778)
  Limit token expiry to 1 hour maximum (elastic#38244)
  add docs saying mixed-cluster ILM is not supported (elastic#37954)
  Skip unsupported languages for tests (elastic#38328)
  Deprecate `_type` in simulate pipeline requests (elastic#37949)
  Mute testCannotShrinkLeaderIndex (elastic#38374)
  Tighten mapping syncing in ccr remote restore (elastic#38071)
  Add test for `PutFollowAction` on a closed index (elastic#38236)
  Fix SSLContext pinning to TLSV1.2 in reload tests (elastic#38341)
  Mute RareClusterStateIT.testDelayedMappingPropagationOnReplica (elastic#38357)
  Deprecate types in rollover index API (elastic#38039)
  Types removal - fix FullClusterRestartIT warning expectations (elastic#38310)
  Fix ILM explain response to allow unknown fields (elastic#38054)
  Mute testFollowIndexAndCloseNode (elastic#38360)
  Docs: Drop inline callout from scroll example (elastic#38340)
  Deprecate HLRC security methods (elastic#37883)
  Remove types from Monitoring plugin "backend" code (elastic#37745)
  Add Composite to AggregationBuilders (elastic#38207)
  Clarify slow cluster-state log messages (elastic#38302)
  ...

@colings86 colings86 added v7.0.0-beta1 and removed v7.0.0 labels Feb 7, 2019

dimitris-athanasiou added a commit to dimitris-athanasiou/elasticsearch that referenced this pull request Feb 12, 2019

Deprecate HLRC security methods (elastic#37883)
This commit deprecates the few methods that had their parameters
reordered to facilitate the move from EmptyResponse to boolean. This
commit also readds the boolean based methods with the proper
signatures.

Relates elastic#37540
Relates elastic#36938
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.