Default include_type_name to false in the yml test harness. #38058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtibshirani
added
:Delivery/Build
|
Pinging @elastic/es-core-infra |
|
Pinging @elastic/es-search |
jtibshirani
force-pushed
the
types-in-rest-tests
branch
from
674a432
to
e7e7f7e
Compare
jtibshirani
force-pushed
the
types-in-rest-tests
branch
from
e7e7f7e
to
2626216
Compare
jtibshirani
force-pushed
the
types-in-rest-tests
branch
from
2626216
to
ee9d68d
Compare
|
@colings86 I might've spoken too soon when I said there weren't too many typed calls left! I'd be happy if you wanted to collaborate on this PR as you mentioned, feel free to push any additional commits. |
colings86
reviewed
Jan 31, 2019
rest-api-spec/src/main/resources/rest-api-spec/test/search/110_field_collapsing.yml
Outdated
Show resolved
Hide resolved
colings86
reviewed
Jan 31, 2019
...framework/src/main/java/org/elasticsearch/test/rest/yaml/ClientYamlTestExecutionContext.java
Show resolved
Hide resolved
colings86
reviewed
Jan 31, 2019
| indices.get_mapping: | ||
| include_type_name: false | ||
|
|
||
| indices.get_mapping: {} |
There was a problem hiding this comment.
I think an extra new line got deleted here?
There was a problem hiding this comment.
👍 will add it back.
|
@elasticmachine run elasticsearch-ci/2 |
jtibshirani
force-pushed
the
types-in-rest-tests
branch
from
6df69a3
to
a3d7ba7
Compare
|
I caught up with @colings86 offline and he was okay with merging after this latest round of fixes. |
48 tasks
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Feb 1, 2019
…ersion * elastic/master: SnapshotShardsService Simplifications (elastic#38025) Default include_type_name to false in the yml test harness. (elastic#38058) Disable bwc preparing to backport of#37977, elastic#37857 and elastic#37872 (elastic#38126) Adding ml_settings entry to HLRC and Docs for deprecation_info (elastic#38118)
jasontedor
added a commit
to bleskes/elasticsearch
that referenced
this pull request
Feb 1, 2019
* elastic/master: AwaitsFix testAbortedSnapshotDuringInitDoesNotStart (elastic#38227) Preserve ILM operation mode when creating new lifecycles (elastic#38134) Enable trace log in FollowerFailOverIT (elastic#38148) SnapshotShardsService Simplifications (elastic#38025) Default include_type_name to false in the yml test harness. (elastic#38058) Disable bwc preparing to backport of#37977, elastic#37857 and elastic#37872 (elastic#38126)
jasontedor
added a commit
to gwbrown/elasticsearch
that referenced
this pull request
Feb 1, 2019
* elastic/master: (54 commits) Introduce retention leases versioning (elastic#37951) Correctly disable tests for FIPS JVMs (elastic#38214) AwaitsFix testAbortedSnapshotDuringInitDoesNotStart (elastic#38227) Preserve ILM operation mode when creating new lifecycles (elastic#38134) Enable trace log in FollowerFailOverIT (elastic#38148) SnapshotShardsService Simplifications (elastic#38025) Default include_type_name to false in the yml test harness. (elastic#38058) Disable bwc preparing to backport of#37977, elastic#37857 and elastic#37872 (elastic#38126) Adding ml_settings entry to HLRC and Docs for deprecation_info (elastic#38118) Replace awaitBusy with assertBusy in atLeastDocsIndexed (elastic#38190) Adjust SearchRequest version checks (elastic#38181) AwaitsFix testClientSucceedsWithVerificationDisabled (elastic#38213) Zen2ify RareClusterStateIT (elastic#38184) ML: Fix error race condition on stop _all datafeeds and close _all jobs (elastic#38113) AwaitsFix PUT mapping with _doc on an index that has types (elastic#38204) Allow built-in monitoring_user role to call GET _xpack API (elastic#38060) Update geo_shape docs to include unsupported features (elastic#38138) [ML] Remove "8" prefixes from file structure finder timestamp formats (elastic#38016) Disable bwc tests while backporting elastic#38104 (elastic#38182) Enable TLSv1.3 by default for JDKs with support (elastic#38103) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the temporary change we made to the yml test harness in #37285 to automatically set
include_type_nametotruein index creation requests if it's not already specified. This is possible now that the vast majority of index creation requests were updated to be typeless in #37611.Additionally, this PR updates the test harness to set
include_type_nametofalsein index creation requests when communicating with 6.x nodes. This mirrors the logic added in #37611 to allow for typeless document write requests in test set-up code. With this update in place, we can remove many references toinclude_type_name: falsefrom the yml tests.