Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct key is "clientip", not only "ip" #38512

Merged
merged 1 commit into from Feb 6, 2019

Conversation

githubfromgui
Copy link
Contributor

If I understood well, whatever name you point to be used, it will be "key' name exported ...

If I understood well, whatever name you point to be used, it will be "key' name exported ...
@colings86 colings86 added the :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP label Feb 6, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features

@jakelandis jakelandis added the >docs General docs changes label Feb 6, 2019
@jakelandis
Copy link
Contributor

@elasticmachine ok to tests
@elasticmachine test this please

@jakelandis jakelandis self-requested a review February 6, 2019 18:02
@jakelandis
Copy link
Contributor

@githubfromgui - thanks for the fix ! I will get this merged to correct versions.

Generally for PR's we ask you to target master, however for doc only changes it doesn't really matter.

@jakelandis jakelandis merged commit 8408797 into elastic:6.6 Feb 6, 2019
jakelandis added a commit to jakelandis/elasticsearch that referenced this pull request Feb 6, 2019
jakelandis added a commit that referenced this pull request Feb 6, 2019
jakelandis added a commit to jakelandis/elasticsearch that referenced this pull request Feb 6, 2019
jakelandis added a commit to jakelandis/elasticsearch that referenced this pull request Feb 6, 2019
jakelandis added a commit to jakelandis/elasticsearch that referenced this pull request Feb 6, 2019
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Feb 8, 2019
* 6.6: (121 commits)
  [DOCS] Add warning about bypassing ML PUT APIs (elastic#38608)
  fix dissect doc "ip" --> "clientip" (elastic#38512)
  bad formatted JSON object (elastic#38515)
  SQL: Fix issue with IN not resolving to underlying keyword field (elastic#38440)
  Update ilm-api.asciidoc, point to REMOVE policy (elastic#38235)
  Backport changes to the release notes script. (elastic#38347)
  Change the milliseconds precision to 3 digits for intervals. (elastic#38297)
  SecuritySettingsSource license.self_generated: trial (elastic#38233) (elastic#38398)
  Fix IndexAuditTrail rolling upgrade on rollover edge 2 (elastic#38286) (elastic#38381)
  Cleanup construction of interceptors (elastic#38388)
  Skip unsupported languages for tests (elastic#38328) (elastic#38385)
  [ILM][TEST] increase assertBusy timeout (elastic#36864) (elastic#38354)
  Docs: Drop inline callout from scroll example (elastic#38340) (elastic#38365)
  Preserve ILM operation mode when creating new lifecycles (elastic#38134) (elastic#38230)
  [ML] Add explanation so far to file structure finder exceptions (elastic#38337)
  ML: Fix error race condition on stop _all datafeeds and close _all jobs (elastic#38113) (elastic#38211) (elastic#38222)
  SQL: Generate relevant error message when grouping functions are not used in GROUP BY (elastic#38017)
  Fix NPE in Logfile Audit Filter (elastic#38120) (elastic#38273)
  Enable trace log in FollowerFailOverIT (elastic#38148)
  Replace awaitBusy with assertBusy in atLeastDocsIndexed (elastic#38190)
  ...
jakelandis added a commit that referenced this pull request Feb 8, 2019
jakelandis added a commit that referenced this pull request Feb 8, 2019
jakelandis added a commit that referenced this pull request Feb 8, 2019
dimitris-athanasiou pushed a commit to dimitris-athanasiou/elasticsearch that referenced this pull request Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP >docs General docs changes v6.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants